Resolve horrific installation-based security issue#19
Merged
scribu merged 1 commit intowp-cli:masterfrom Jul 26, 2013
grahamc:patch-1
Merged
Resolve horrific installation-based security issue#19scribu merged 1 commit intowp-cli:masterfrom grahamc:patch-1
scribu merged 1 commit intowp-cli:masterfrom
grahamc:patch-1
Conversation
Expecting HTTP traffic to not be mangled, especially when a potential attacker knows users are planning on piping it directly to bash, is a horrifying idea. Instead, link to the HTTPS version hosted on github.com. Same outcome, less horribleness.
Member
|
It didn't occur to me to use raw.github.com. Thanks! Wondering if we should go one step further and disable access to http://wp-cli.org/installer.sh (Jekyll supports that). |
scribu
pushed a commit
that referenced
this pull request
Jul 26, 2013
Resolve horrific installation-based security issue
Contributor
Author
|
I'd recommend it :) |
schlessera
pushed a commit
that referenced
this pull request
Jan 25, 2022
Resolve horrific installation-based security issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expecting HTTP traffic to not be mangled, especially when a potential attacker
knows users are planning on piping it directly to bash, is a horrifying idea.
Instead, link to the HTTPS version hosted on github.com. Same outcome, less
horribleness.