Fix MySQL8 column-statistics compatibility issue#71
Merged
schlessera merged 8 commits intowp-cli:masterfrom Nov 3, 2019
Merged
Fix MySQL8 column-statistics compatibility issue#71schlessera merged 8 commits intowp-cli:masterfrom
schlessera merged 8 commits intowp-cli:masterfrom
Conversation
skip column statistics in mysql8
Closed
schlessera
requested changes
Nov 3, 2019
| self::dir_diff_copy( $run_dir, self::$cache_dir, $install_cache_path ); | ||
| self::run_sql( 'mysqldump --no-defaults', array( 'result-file' => "{$install_cache_path}.sql" ), true /*add_database*/ ); | ||
|
|
||
| $support_column_statistics = exec( 'mysqldump --help | grep "column-statistics"' ); |
Member
There was a problem hiding this comment.
We should stick to one way to locating the mysqldump binary only:
Suggested change
| $support_column_statistics = exec( 'mysqldump --help | grep "column-statistics"' ); | |
| $support_column_statistics = exec( '/usr/bin/env mysqldump --help | grep "column-statistics"' ); |
Co-Authored-By: Alain Schlesser <alain.schlesser@gmail.com>
this isn't the right way to test a different version of mysql. will create an issue in the framework repo for further investigation
schlessera
requested changes
Nov 3, 2019
Co-Authored-By: Alain Schlesser <alain.schlesser@gmail.com>
Co-Authored-By: Alain Schlesser <alain.schlesser@gmail.com>
schlessera
approved these changes
Nov 3, 2019
Member
|
Thanks for the PR, @jacklowrie ! |
schlessera
added a commit
that referenced
this pull request
Jan 5, 2022
Fix MySQL8 column-statistics compatibility issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request ensures that column-statistics is not used if supported by the user's version of mysql. If column-statistics are supported by the user's version of mysql supports column-statistics, the
--skip-column-statisticstag is added to themysqldumpcommand.This is related to #4, wp-cli/db-command#103, and wp-cli/db-command#105