Skip to content

Use realpath() when comparing paths#7

Merged
schlessera merged 1 commit intomasterfrom
6-realpath
Aug 2, 2018
Merged

Use realpath() when comparing paths#7
schlessera merged 1 commit intomasterfrom
6-realpath

Conversation

@swissspidy
Copy link
Copy Markdown
Member

@swissspidy swissspidy commented Aug 2, 2018

This fixes #6 and resolves the problem I had with wp-cli/language-command#38.

@swissspidy swissspidy requested a review from a team August 2, 2018 13:39
@schlessera schlessera added bug Something isn't working scope:testing labels Aug 2, 2018
@schlessera schlessera merged commit e2c505c into master Aug 2, 2018
@schlessera schlessera deleted the 6-realpath branch August 2, 2018 13:47
@schlessera
Copy link
Copy Markdown
Member

I think this might have introduced a test failure in wp-cli/wp-cli on WordPress 3.7: https://travis-ci.org/wp-cli/wp-cli/jobs/411844079#L695

@swissspidy
Copy link
Copy Markdown
Member Author

Interesting 🤔

What's the value of {PACKAGE_PATH} at that point? Does realpath() perhaps return false because of an unexpected value?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working scope:testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect temp dir check on macOS

2 participants