Skip to content

Address deprecation warnings in Behat tests #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 4 commits into from
Oct 9, 2024
Merged

Address deprecation warnings in Behat tests #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ddef12d
Address deprecations in test code
swissspidy Oct 1, 2024
7312d92
Skip Requests v1 test on PHP 8.2+
swissspidy Oct 1, 2024
1df0e7a
Fix trunk tests
swissspidy Oct 1, 2024
1676eb8
Merge branch 'main' into fix-tests-deprecations
swissspidy Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions features/command.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,7 @@ Feature: WP-CLI Commands
"""
<?php
class Foo_Class extends WP_CLI_Command {
protected $prefix;

public function __construct( $prefix ) {
$this->prefix = $prefix;
Expand Down Expand Up @@ -478,6 +479,7 @@ Feature: WP-CLI Commands
"""
<?php
class Foo_Class {
protected $message;

public function __construct( $message ) {
$this->message = $message;
Expand Down Expand Up @@ -1119,6 +1121,7 @@ Feature: WP-CLI Commands
"""
<?php
class Foo_Class {
protected $message;

public function __construct( $message ) {
$this->message = $message;
Expand Down
7 changes: 6 additions & 1 deletion features/requests.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
Feature: Requests integration with both v1 and v2

# This test downgrades to WordPress 5.8, but the SQLite plugin requires 6.0+
@require-mysql
# WP-CLI 2.7 causes deprecation warnings on PHP 8.2
@require-mysql @less-than-php-8.2
Scenario: Composer stack with Requests v1
Given an empty directory
And a composer.json file:
Expand Down Expand Up @@ -78,6 +79,10 @@ Feature: Requests integration with both v1 and v2

Scenario: Current version with WordPress-bundled Requests v2
Given a WP installation
# Switch themes because twentytwentyfive requires a version newer than 6.2
# and it would otherwise cause a fatal error further down.
And I try `wp theme install twentyten`
And I try `wp theme activate twentyten`
And I run `wp core update --version=6.2 --force`

When I run `wp core version`
Expand Down