Skip to content

Remove unused pre-commit scripts#596

Merged
swissspidy merged 1 commit intowp-cli:mainfrom
johnbillion:remove-pre-commit
Nov 10, 2023
Merged

Remove unused pre-commit scripts#596
swissspidy merged 1 commit intowp-cli:mainfrom
johnbillion:remove-pre-commit

Conversation

@johnbillion
Copy link
Copy Markdown
Contributor

See wp-cli/wp-cli#5480.

This removes the script which sets up the pre-commit hook and its corresponding script. Unlike in wp-cli/wp-cli#5868 here is nothing to remove from composer.json, which means these scripts are not in use anyway.

If you have this pre-commit script installed, you can remove it by deleting the .git/hooks/pre-commit file.

Steps for testing

  1. Clone this repo
  2. Run composer install
  3. Confirm no pre-commit hook has been installed into .git/hooks/pre-commit
  4. Commit some code that would normally fail coding standards checks
  5. Confirm there's no error message and the commit succeeds

@johnbillion johnbillion requested a review from a team as a code owner November 10, 2023 15:44
@swissspidy swissspidy added the scope:testing Related to testing label Nov 10, 2023
@swissspidy swissspidy merged commit 0014392 into wp-cli:main Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants