Skip to content

Handle files with the .php8 extension - #263

Merged
schlessera merged 3 commits into
wp-cli:fix/gha-functional-tests-updatefrom
alexholt:handle-php8-file-extension
Mar 5, 2021
Merged

schlessera merged 3 commits into
wp-cli:fix/gha-functional-tests-updatefrom
alexholt:handle-php8-file-extension

Conversation

@alexholt

Copy link
Copy Markdown
Contributor

This is necessary in order for the phar to include:
symfony/polyfill-mbstring/Resources/mb_convert_variables.php8

This is necessary in order for the phar to include
symfony/polyfill-mbstring/Resources/mb_convert_variables.php8
@alexholt
alexholt requested a review from a team as a code owner February 11, 2021 04:13
swissspidy
swissspidy previously approved these changes Feb 12, 2021

@swissspidy swissspidy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting!

@swissspidy

Copy link
Copy Markdown
Member

I think we could just bump the composer dependency instead.

@swissspidy
swissspidy dismissed their stale review February 12, 2021 17:54

changed my mind

But they are not needed for this
@alexholt
alexholt force-pushed the handle-php8-file-extension branch from 5bcffb4 to 13c61fc Compare February 13, 2021 00:35
if: steps.check_files.outputs.files_exists == 'true'
run: |
export MYQSL_HOST=127.0.0.1
export MYSQL_HOST=127.0.0.1

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦

@schlessera
schlessera changed the base branch from master to fix/gha-functional-tests-update March 5, 2021 12:30
@schlessera schlessera added this to the 2.5.0 milestone Mar 5, 2021
@schlessera schlessera added the bug Something isn't working label Mar 5, 2021
@schlessera
schlessera merged commit 3cbbf02 into wp-cli:fix/gha-functional-tests-update Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants