Repository navigation
Only ask PHP for its OS where a Windows path can be needed - #6442
Draft
schlessera wants to merge 1 commit into
Draft
schlessera wants to merge 1 commit into
schlessera wants to merge 1 commit into
Conversation
The launcher started an extra PHP process on every invocation to check whether PHP runs on Windows, which only matters when a Windows PHP is run from Cygwin or MSYS. Skip the check where cygpath is not available. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses wp-cli/wp-cli-tests#389.
The
wplauncher starts PHP twice on every invocation: once to runphp -r "echo PHP_OS;", and once to run WP-CLI. The first one only matters when a Windows PHP is run from Cygwin or MSYS, where the script path has to be converted withcygpath.The check now only runs where
cygpathis available, so Cygwin and MSYS behave as before, and every other environment saves a PHP process per command. Locally,wp cli versionwent from about 102 ms to 81 ms. The test suites of the bundled commands make well over 10,000wpcalls per run.Measurements are recorded on wp-cli/wp-cli-tests#389.