Repository navigation
Use wp_parse_args() where we can - #643
Merged
Merged
Conversation
Member
There was a problem hiding this comment.
If we're going to make this change, let's do it right:
Rename $values to $defaults and assign the result from wp_parse_args() to $assoc_args.
Member
|
Actually, since we assign the defaults to a variable, I don't see much benefit in using |
Member
Agree, particularly because we don't need to accept a string of arguments. |
Contributor
Author
|
Agreed |
Member
|
@johnbillion will you update your PR or should someone else handle it? |
Contributor
Author
|
Yep I'll get it updated |
Contributor
Author
|
I made the mistake of doing these changes on the master branch. Learnt my lesson now. |
scribu
pushed a commit
that referenced
this pull request
Aug 14, 2013
Use `wp_parse_args()` where we can
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of methods use some code which can be replaced with
wp_parse_args()for simplicity.