Skip to content

Bug: wp plugin install installs a plugin when it shouldn't - #633

Merged
scribu merged 3 commits into
masterfrom
fix-633
Aug 5, 2013
Merged

scribu merged 3 commits into
masterfrom
fix-633

Conversation

@scribu

@scribu scribu commented Aug 5, 2013

Copy link
Copy Markdown
Member

I did: wp plugin install

I saw:

hmn-vagrant ➜  wordpress-trunk.dev  wp plugin install
PHP Notice:  Undefined offset: 0 in /home/vagrant/.wp-cli/vendor/wp-cli/wp-cli/php/WP_CLI/CommandWithUpgrade.php on line 101
Installing BFT Autoresponder (2.0)
Downloading install package from http://downloads.wordpress.org/plugin/bft-autoresponder.zip...
Unpacking the package...
Installing the plugin...
Plugin installed successfully.

I expected: to see usage instructions.

@scribu

scribu commented Aug 5, 2013

Copy link
Copy Markdown
Member

Related: #229

@scribu

scribu commented Aug 5, 2013

Copy link
Copy Markdown
Member

But yeah, not sure why the synopsis validator doesn't kick in.

@scribu

scribu commented Aug 5, 2013

Copy link
Copy Markdown
Member

It's a regression. In WP-CLI 0.10.2, it works as expected:

$ wp plugin install
usage: wp plugin install <plugin|zip> [--version=<version>] [--activate]

scribu added 3 commits August 5, 2013 22:59
It's better to test for the specific bug, when possible.

This reverts commit d6287f7.
scribu pushed a commit that referenced this pull request Aug 5, 2013
Bug: `wp plugin install` installs a plugin when it shouldn't
@scribu
scribu merged commit b2e47e0 into master Aug 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants