Skip to content

Validate downloaded files before adding to cache #6149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dhruvang21 wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Validate downloaded files before adding to cache #6149

dhruvang21 wants to merge 12 commits into from

Conversation

@dhruvang21
Copy link

@dhruvang21 dhruvang21 commented Nov 11, 2025

@dhruvang21 dhruvang21 requested a review from a team as a code owner November 11, 2025 13:39
swissspidy
swissspidy reviewed Nov 11, 2025
View reviewed changes
Copy link
Member

@swissspidy swissspidy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your PR!

@swissspidy swissspidy requested a review from Copilot November 11, 2025 13:58

This comment was marked as resolved.

Sign in to view

@codecov
Copy link

codecov bot commented Nov 11, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 55.55556% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
php/WP_CLI/WpHttpCacheManager.php 55.55% 12 Missing ⚠️

📢 Thoughts on this report? Let us know!

dhruvang21 and others added 2 commits November 12, 2025 11:10
@dhruvang21 @swissspidy
Update warning message
6983b03 
Co-authored-by: Pascal Birchler <pascal.birchler@gmail.com>
@dhruvang21
refactor: code suggestions
397bb1b
@swissspidy swissspidy requested a review from a team November 12, 2025 11:10
@swissspidy swissspidy requested a review from Copilot December 2, 2025 20:20
Copilot AI reviewed Dec 2, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

dhruvang21 and others added 4 commits December 3, 2025 11:21
@swissspidy swissspidy added this to the 3.0.0 milestone Jan 21, 2026
@swissspidy swissspidy changed the title Check cache file validation Validate downloaded files before adding to cache Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@swissspidy swissspidy swissspidy approved these changes

Assignees

No one assigned

Labels

bug command:cache

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

Cache file validation in cache manager

2 participants

@dhruvang21 @swissspidy