-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix tilde (~) expansion in --path parameter #6141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Copilot
wants to merge
7
commits into
main
Choose a base branch
from
copilot/fix-home-symbol-translation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix translation of home symbol in wp-cli path parameter
Fix tilde (~) expansion in --path parameter
Nov 2, 2025
Copilot finished work on behalf of
swissspidy
November 2, 2025 15:54
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
swissspidy
reviewed
Nov 2, 2025
Co-authored-by: swissspidy <841956+swissspidy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Home Symbol (~) Translation in --path Parameter ✅
Summary
This PR successfully fixes the issue where the
--pathparameter and config filepathsetting do not translate the tilde (~) symbol to the user's home directory.Changes Made:
Core Implementation:
expand_tilde_path()function inphp/utils.phpto expand tilde (~) to home directoryRunner.php::find_wp_root()to callexpand_tilde_path()before processing pathsConfigurator.php::absolutize()to handle tilde expansion in config filesTests:
tests/UtilsTest.phpfor theexpand_tilde_path()functionfeatures/flags.featurefor--path=~/...usage (fixed to use correct Behat steps)features/config.featurefor config filepath: ~/...usage (fixed to use correct Behat steps)Documentation:
~usernamepatterns)Implementation Details:
The solution expands the tilde (~) character at the beginning of a path to the user's home directory:
~→/home/user~/sites/wordpress→/home/user/sites/wordpress~(current user), not~usernamesyntax (documented and intentional)Testing Results:
✅ All tests pass:
~expands to home directory~/pathexpands to home directory + path~usernamepatterns are not expanded (as documented)Example Usage:
Before this fix:
After this fix:
Files Modified:
php/utils.php- Addedexpand_tilde_path()helper functionphp/WP_CLI/Runner.php- Updated to use tilde expansionphp/WP_CLI/Configurator.php- Updated to use tilde expansiontests/UtilsTest.php- Added unit testsfeatures/flags.feature- Added feature test for --path parameterfeatures/config.feature- Added feature test for config fileThis fix resolves the issue reported where
--path=~/sites/wordpresswas not being properly expanded to the user's home directory.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.