Skip to content

Add test for line breaks in table view #6055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrsdizzie merged 11 commits into from
Mar 4, 2025
+37 −1
Merged

Add test for line breaks in table view #6055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
42f80d0
Fix line break issue for table view
BhargavBhandari90 Mar 1, 2025
529eb8b
add preincreament
BhargavBhandari90 Mar 1, 2025
71b6115
Make item dynamic as per fields
BhargavBhandari90 Mar 2, 2025
f55dff6
Add code comments
BhargavBhandari90 Mar 2, 2025
a99f207
Added behat test for checking linebreak in formatter
BhargavBhandari90 Mar 2, 2025
4113a04
Undo formatter change
swissspidy Mar 3, 2025
01c9a2b
Require latest php-cli-tools version
swissspidy Mar 3, 2025
9b69849
Merge branch 'main' into line-break-improvement
swissspidy Mar 3, 2025
7288c65
Adjust scenario title
swissspidy Mar 3, 2025
d201b49
Merge branch 'main' into line-break-improvement
swissspidy Mar 4, 2025
7a3b5d7
Use v0.12.3 of php-cli-tools
swissspidy Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"mustache/mustache": "^2.14.1",
"symfony/finder": ">2.7",
"wp-cli/mustangostang-spyc": "^0.6.3",
"wp-cli/php-cli-tools": "~0.12.1"
"wp-cli/php-cli-tools": "~0.12.3"
},
"require-dev": {
"roave/security-advisories": "dev-latest",
Expand Down
36 changes: 36 additions & 0 deletions features/formatter.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,3 +153,39 @@ Feature: Format output
| gaa/gaa-log | * | ✔ |
| gaa/gaa-nonsense | v3.0.11 | 🛇 |
| gaa/gaa-100%new | v100%new | ✔ |

Scenario: Table rows containing linebreaks
Given an empty directory
And a file.php file:
"""
<?php
$items = array(
(object) array(
'post_id' => 1,
'meta_key' => 'foo',
'meta_value' => 'foo',
),
(object) array(
'post_id' => 1,
'meta_key' => 'fruits',
'meta_value' => "apple\nbanana\nmango",
),
(object) array(
'post_id' => 1,
'meta_key' => 'bar',
'meta_value' => 'br',
),
);
$assoc_args = array();
$formatter = new WP_CLI\Formatter( $assoc_args, array( 'post_id', 'meta_key', 'meta_value' ) );
$formatter->display_items( $items );
"""

When I run `wp eval-file file.php --skip-wordpress`
Then STDOUT should be a table containing rows:
| post_id | meta_key | meta_value |
| 1 | foo | foo |
| 1 | fruits | apple |
| | | banana |
| | | mango |
| 1 | bar | br |
Loading