UtilsTest: fix the test failure#5997
Merged
swissspidy merged 5 commits intowp-cli:mainfrom Oct 1, 2024
Merged
Conversation
Tests on PHP 8.1 and higher (which are running PHPUnit 10+) are failing with the below message: ``` An error occurred inside PHPUnit. Message: Interface "WpOrg\Requests\Transport" not found Location: /home/runner/work/wp-cli/wp-cli/tests/mock-requests-transport.php:6 ``` This may be due to the test classes being loaded (to count the number of tests) before the test bootstrap is being run (which includes the autoloaders). If that "guess" is correct, this patch should fix this.
While these tests are not showing errors at this time, it is still best practice to include files in the test `set_up_before_class()` method, not when the file is being read. This applies this change to all other test files which were using the anti-pattern.
Member
|
@jrfnl I found the issue! 🎉 So, these failures on PHP 8.1+ happen only when the config is migrated using For PHPUnit tests we specify two bootstrap files:
This regex pattern - The problem is, with the migrated configuration, all the attributes in the XML file are on one line, so the regex matched way more than just wp-cli/wp-cli-tests#224 should fix this |
Member
|
Much better now: |
swissspidy
approved these changes
Oct 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UtilsTest: fix the test failure
Tests on PHP 8.1 and higher (which are running PHPUnit 10+) are failing with the below message:
This may be due to the test classes being loaded (to count the number of tests) before the test bootstrap is being run (which includes the autoloaders).
If that "guess" is correct, this patch should fix this.
Tests: apply the same change to other test files
While these tests are not showing errors at this time, it is still best practice to include files in the test
set_up_before_class()method, not when the file is being read.This applies this change to all other test files which were using the anti-pattern.