Skip to content

PHP 8.1 | WP_CLI\Iterators\CSV: fix "missing return type" deprecation warnings #5983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 1 commit into from
Sep 17, 2024
Merged

PHP 8.1 | WP_CLI\Iterators\CSV: fix "missing return type" deprecation warnings #5983

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions php/WP_CLI/Iterators/CSV.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@

use Countable;
use Iterator;
use ReturnTypeWillChange;
use SplFileObject;
use WP_CLI;

Expand Down Expand Up @@ -33,6 +34,7 @@ public function __construct( $filename, $delimiter = ',' ) {
$this->delimiter = $delimiter;
}

#[ReturnTypeWillChange]
public function rewind() {
rewind( $this->file_pointer );

Expand All @@ -42,14 +44,17 @@ public function rewind() {
$this->next();
}

#[ReturnTypeWillChange]
public function current() {
return $this->current_element;
}

#[ReturnTypeWillChange]
public function key() {
return $this->current_index;
}

#[ReturnTypeWillChange]
public function next() {
$this->current_element = false;

Expand All @@ -76,12 +81,14 @@ public function next() {
}
}

#[ReturnTypeWillChange]
public function count() {
$file = new SplFileObject( $this->filename, 'r' );
$file->seek( PHP_INT_MAX );
return $file->key() + 1;
}

#[ReturnTypeWillChange]
public function valid() {
return is_array( $this->current_element );
}
Expand Down