Skip to content

PHP 8.4 | Fix implicitly nullable parameters #5982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 1 commit into from
Sep 17, 2024
Merged

PHP 8.4 | Fix implicitly nullable parameters #5982

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions php/WP_CLI/Runner.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1948,16 +1948,19 @@ private function auto_check_update() {
* Get a suggestion on similar (sub)commands when the user entered an
* unknown (sub)command.
*
* @param string $entry User entry that didn't match an
* existing command.
* @param CompositeCommand $root_command Root command to start search for
* suggestions at.
* @param string $entry User entry that didn't match an
* existing command.
* @param CompositeCommand|null $root_command Root command to start search for
* suggestions at.
*
* @return string Suggestion that fits the user entry, or an empty string.
*/
private function get_subcommand_suggestion( $entry, CompositeCommand $root_command = null ) {
private function get_subcommand_suggestion( $entry, $root_command = null ) {
$commands = [];
$this->enumerate_commands( $root_command ?: WP_CLI::get_root_command(), $commands );
if ( ( $root_command instanceof CompositeCommand ) === false ) {
$root_command = WP_CLI::get_root_command();
}
$this->enumerate_commands( $root_command, $commands );

return Utils\get_suggestion( $entry, $commands, $threshold = 2 );
}
Expand Down