Add defaults and accepted values for runcommand() options in doc#5953
Add defaults and accepted values for runcommand() options in doc#5953mrsdizzie merged 7 commits intowp-cli:mainfrom
Conversation
mrsdizzie
left a comment
mrsdizzie
left a comment
There was a problem hiding this comment.
This is already somewhat documented in the same docblock right above this change and you can see it here: https://make.wordpress.org/cli/handbook/references/internal-api/wp-cli-runcommand/
Which documents all elements and some accepted values, but doesn't include defaults or full descriptions.
This new documentation looks to be missing command_args from the options array also. I added some suggestions for more detailed descriptions based on what the code actually does (which wasn't previously documented in full in the comments)
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
mrsdizzie
left a comment
mrsdizzie
left a comment
There was a problem hiding this comment.
I committed all my previous suggestions since there was no response from the author and we might as well use them
6 participants
Description
Update runcommand doc to add default and accepted values.