Ensure the alias has the leading @ symbol when added#5924
Ensure the alias has the leading @ symbol when added#5924swissspidy merged 3 commits intowp-cli:mainfrom
@ symbol when added#5924Conversation
|
Hey @swissspidy, about the PHPCS issue...
It looks like the issue has been around for a while as the file affected has been untouched in this PR. Should we fix it in this PR, or should I create a separate issue or PR for it? |
|
Yeah it probably only got surfaced now because of an unrelated PHPCS update and there not being any other code changes recently. Given the great state of this PR (thanks a lot for your work on this!) I'd say let's fix it as part of this PR. Should be as trivial as adding some parentheses :) |
features/aliases.feature
Outdated
| """ | ||
| Success: Added '@hello' alias. | ||
| """ |
There was a problem hiding this comment.
The indentation looks a bit off here
There was a problem hiding this comment.
@swissspidy Good catch :) I've pushed an update to fix it.
Does the indentation look correct?
Let me know if there's anything else I might've missed.
2 participants
This pull request aims to address the issue reported in #5391 where adding an alias without the
@symbol would result in the alias being added but missing from the output of thewp cli alias listcommand because it does not have the@symbol. With the updates in this pull request, if the user forgets to provide the@symbol as the prefix, it will be added behind the scenes to ensure the alias can be listed correctly.