Closed
Conversation
mrsdizzie
approved these changes
Mar 20, 2024
danielbachhuber
changed the title
| function mustache_render( $template_name, $data = [] ) { | ||
| if ( ! file_exists( $template_name ) ) { | ||
| $template_name = WP_CLI_ROOT . "/templates/$template_name"; | ||
| $template_name = phar_safe_path( WP_CLI_ROOT . "/templates/$template_name" ); |
Member
There was a problem hiding this comment.
Should we add a test for this? Also, can we document the nature of the change in the PR description?
Contributor
Author
There was a problem hiding this comment.
@danielbachhuber PR description updated. I don't know how to write test for this change.
Member
danielbachhuber
left a comment
danielbachhuber
left a comment
There was a problem hiding this comment.
@wojsmol Were you able to reproduce the original issue and confirm that this fixes it?
I'm a little unclear that this is the actual solution. In reviewing #4689 (comment), wp config create is already passing a Phar-safe path:
As such, the file_exists() check should return true and this particular block of code shouldn't be executed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #4689
Fixes paths used for accessing the Mustache template files within the Phar file will need to be wrapped in
Utils\phar_safe_path().