Merged
Conversation
swissspidy
approved these changes
Feb 6, 2024
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please see #5896 for details and code to replicate.
tl;dr In versions of PHP greater than 8.1.x, when
WP_CLI::error()andWP_CLI::halt()are called in a separate command viaWP_CLI::runcommand(), thenPHP Deprecatednotices are written to the logs. Passing an empty string is compatible with the signature of theExceptionconstructor and avoids the warnings.Edit: since there are no functional changes in this PR, I haven't included tests.