Revert the revert of the Move of RecursiveDataStructureTraverser to wp-cli/wp-cli#5871
Merged
schlessera merged 3 commits intomainfrom Nov 14, 2023
Merged
Conversation
swissspidy
approved these changes
Nov 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit a4303bc (which reverted commit d0d2a34 😅)
See discussion in #5866
It also changes the namespaces to be singular, as that is the best practice in PHP. I'ma ware that we already have plural namespaces in the package, but that doesn't preclude us from doing it correctly for all new subnamespaces, given that a consumer will not see all other subnamespaces anyway.