Update type hint of $callable parameter in add_command() method#5828
Merged
danielbachhuber merged 1 commit intowp-cli:mainfrom Aug 18, 2023
Merged
Update type hint of $callable parameter in add_command() method#5828danielbachhuber merged 1 commit intowp-cli:mainfrom
danielbachhuber merged 1 commit intowp-cli:mainfrom
Conversation
The $callable can be a class name or an object as well, so allow `object` and `string` types in the type hint.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
$callablecan be a class name or an object as well, so allowobjectandstringtypes in the type hint.I've noticed this issue while analyzing a plugin of mine with PHPStan on level 7.