Skip to content

Extract Requests out of Composer#5796

Merged
schlessera merged 4 commits intomainfrom
fix/extract-requests-out-of-composer
Jun 3, 2023
Merged

Extract Requests out of Composer#5796
schlessera merged 4 commits intomainfrom
fix/extract-requests-out-of-composer

Conversation

@schlessera
Copy link
Member

Related #5795

When using Composer to pull in both WordPress Core and WP-CLI, the static files autoloading that Composer applies to the Requests library causes fatal issues.

This PR extract the Requests library out of the Composer dependencies and it commits it as part of the source. We had already been manually controlling the autoloading of the Requests library to get around the lack of WordPress Core dependency management, so this step only completes the approach we've already been taking.

Note that this is certainly not the correct way of handling a dependency. However, the combination of how WordPress doesn't handle its dependencies and the requirement of WP-CLI to work across all permutations of old/new Core and old/new WP-CLI forces our hand in this case.

@schlessera schlessera added this to the 2.8.1 milestone Jun 3, 2023
@schlessera schlessera requested a review from a team as a code owner June 3, 2023 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant