Skip to content

Conditionally adapt to Core Requests library#5783

Merged
schlessera merged 7 commits intomainfrom
fix/conditionally-adapt-to-core-requests
May 11, 2023
Merged

Conditionally adapt to Core Requests library#5783
schlessera merged 7 commits intomainfrom
fix/conditionally-adapt-to-core-requests

Conversation

@schlessera
Copy link
Member

@schlessera schlessera commented May 5, 2023

This PR changes the logic to integrate with Requests so that it conditionally adapts to the version that ships with WordPress Core or falls back to the bundled one as needed.

@schlessera schlessera requested a review from a team as a code owner May 5, 2023 16:28
@schlessera schlessera added this to the 2.8.0 milestone May 5, 2023
@schlessera schlessera force-pushed the fix/conditionally-adapt-to-core-requests branch from f39ed99 to ea3d695 Compare May 5, 2023 16:43
@schlessera schlessera force-pushed the fix/conditionally-adapt-to-core-requests branch from 4e2a010 to 1dec519 Compare May 5, 2023 17:22
@schlessera schlessera force-pushed the fix/conditionally-adapt-to-core-requests branch from 1dec519 to 2b21853 Compare May 5, 2023 17:26
@danielbachhuber danielbachhuber mentioned this pull request May 8, 2023
Merged
@danielbachhuber
Copy link
Member

danielbachhuber commented May 8, 2023

As a FYI, I'm getting this error in wp-cli-dev:

$ wp maintenance release generate entity-command

Fatal error: Uncaught Error: Class "WpOrg\Requests\Autoload" not found in /Users/danielbachhuber/projects/wp-cli-dev/wp-cli/php/WP_CLI/Bootstrap/IncludeRequestsAutoloader.php:83
Stack trace:
#0 /Users/danielbachhuber/projects/wp-cli-dev/wp-cli/php/bootstrap.php(83): WP_CLI\Bootstrap\IncludeRequestsAutoloader->process(Object(WP_CLI\Bootstrap\BootstrapState))
#1 /Users/danielbachhuber/projects/wp-cli-dev/wp-cli/php/wp-cli.php(32): WP_CLI\bootstrap()
#2 /Users/danielbachhuber/projects/wp-cli-dev/wp-cli/php/boot-fs.php(17): require_once('/Users/danielba...')
#3 {main}
  thrown in /Users/danielbachhuber/projects/wp-cli-dev/wp-cli/php/WP_CLI/Bootstrap/IncludeRequestsAutoloader.php on line 83

@danielbachhuber
Copy link
Member

danielbachhuber commented May 8, 2023

As a FYI, I'm getting this error in wp-cli-dev

Deleting wp-cli-dev/composer.lock and running composer install fixed the issue for me.

@schlessera schlessera merged commit 78ee8b3 into main May 11, 2023
@schlessera schlessera deleted the fix/conditionally-adapt-to-core-requests branch May 11, 2023 13:35
@danielbachhuber danielbachhuber mentioned this pull request May 17, 2023
Closed
@jmtorres
Copy link

jmtorres commented Aug 15, 2023

This doesn't seem to resolve the case when connecting to a remote WP site through SSH with an alias (and probably by other means). I submitted another issue in relation to this: #5816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

internal-api:wp-cli-utils-http-request scope:bootstrap

Projects

None yet

Milestone

2.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@schlessera @danielbachhuber @jmtorres