PS: Passing args and assoc_args to the callback would add even more context, making it possible to do validation of arguments in the before_invoke hook.

I haven't done so in the PR in order to avoid too many modifications, but if there's interest I'll make another PR or edit this one.

Thanks,
Cocco

Ciao @danielbachhuber, and thank you for your reply!

I had a command structured in this way:

<?php

class TestHook
{
    public function __invoke( $args )
    {
        WP_CLI::line( "In command" );
    }
}

WP_CLI::add_command(
    'test hook', // two words
    'TestHook',
    [
        'before_invoke' => function() {
            WP_CLI::line( "In before_invoke" );
        },
        'after_invoke' => function() {
            WP_CLI::line( "In after_invoke" );
        }
    ]
);

When I invoked the command, I was suprised getting the following output:

$ wp test my hook
In before_invoke
In before_invoke
In command
In after_invoke
In after_invoke

Please note that by changing the command's name to a single word (e.g. testhook instead of test hook), it works fine.

The problem originates here. The easiest fix would be to just remove the WP_CLI::do_hook( "before_invoke:{$parent}" ); line, but I am not sure what the side effects would be.

Thanks for the clarification, @coccoinomane !

I think the backwards-compat approach approach makes most sense too. The downside risk of unexpected explosions outweighs any upside of making this absolutely correct, in my opinion.

I'll flag for a review from @schlessera too.

Sure, thanks 👍

To add context, I am using the hooks in this new project > https://github.com/Idearia/wp-cli-command

The idea is to register hooks by simply overriding a method 🙂