Autocomplete --url (autoclosed by history purge)#5675
Autocomplete --url (autoclosed by history purge)#5675iandunn wants to merge 9883 commits intowp-cli:masterfrom
--url (autoclosed by history purge)#5675Conversation
Update docblocks for methods that accept error objects
…ull-value Harden error message on failed cache directory creation
…equest-verify-option
Add missing `$pipes` variables when creating processes
…5-08 Update Composer dependencies - 2021-05-08
…-plugins Add `johnpbloch/wordpress-core-installer` to `allowed-plugins`
According to the docblock, the method is supposed to default to the current working dir, but in reality it could return `null` if nothing was found. This breaks other methods like `::set_wp_root()` which expect a string. Prevents PHP deprecation notices because `null` was passed to `realpath()`.
Prevents PHP deprecation notices when inadvertently passing `null` to the function and thus `rtrim`.
Add missing filter argument
Address some PHP 8.1 deprecation notices
…-in-test-scenarios Require `v3.1.6` of `wp-cli/wp-cli-tests`
Co-authored-by: Alain Schlesser <alain.schlesser@gmail.com>
Co-authored-by: Daniel Bachhuber <daniel.bachhuber@automattic.com>
…or-admin-context-logix Use different action for admin context logic
|
@schlessera , do you have any thoughts on this? |
|
@iandunn Thanks for the work on this. It would certainly be nice to have autocompletion for URLs. |
How about something simple, like only enabling autocompletion if Combined with caching an alphabetized list of domains/paths on disk, that seems like it'd be performant. If it's not, we can always drop the number to 5,000 or whatever is performant. Psuedocode: That way the only potential bottleneck for the user is processing the cache file: |
|
Proceeding with #5594 for this repository. I've captured this PR to https://gist.github.com/danielbachhuber/f825f836ba8d9ed5270a8f1eff0e5d3d in case this PR is auto-closed or broken in some way. |
314a242 to
1e9ebdf
Compare
--url--url (autoclosed by history purge)
This was closed by the history purge, and has been restarted in #5704.
Fixes #5256
This adds tab completion for the global
--urlparameter, to make it more convenient to type long URLs in Multisite environments.> wp cron event list --url=foo foo.example.org foot.example.org football.example.orgThis is just a rough sketch at the moment. There are some unanswered questions, and I haven't even tried running the tests. I'd just like to get feedback on the general approach etc before putting too much time into it.
Are there any fundamental things that should change? Or does it basically look good and just needs to be finished?