Always return PHP_BINARY when using a PHAR bundle#5672
Merged
danielbachhuber merged 1 commit intowp-cli:masterfrom Sep 11, 2022
gocodebox:issue/5615
Merged
Always return PHP_BINARY when using a PHAR bundle#5672danielbachhuber merged 1 commit intowp-cli:masterfrom gocodebox:issue/5615
danielbachhuber merged 1 commit intowp-cli:masterfrom
gocodebox:issue/5615
Conversation
Member
danielbachhuber
left a comment
danielbachhuber
left a comment
There was a problem hiding this comment.
Thanks for the pull request, @thomasplevy !
One small comment for you.
Contributor
Author
|
cool cool cool 🚢 |
This was referenced Oct 31, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a check to the
get_php_binary()utility method so that when runningwp-clias a PHAR bundle thewp --infocommand will always output the shell's current PHP version.Fixes #5615
I believe this is a safe method of determining whether or not the
wp-clibinary is a PHAR or not but if there's a preferred or better method I'll switch this to that.Existing tests pass and I didn't add any new ones due to the usage of the constant.