Use different action for admin context logic#5663
Merged
schlessera merged 6 commits intomasterfrom Sep 2, 2022
Merged
Conversation
schlessera
force-pushed
the
fix/use-different-action-for-admin-context-logix
branch
from
ff95cfe to
d0c788e
Compare
Co-authored-by: Daniel Bachhuber <daniel.bachhuber@automattic.com>
schlessera
force-pushed
the
fix/use-different-action-for-admin-context-logix
branch
from
6bb2634 to
db58bb5
Compare
schlessera
force-pushed
the
fix/use-different-action-for-admin-context-logix
branch
from
f507e7b to
caea7ec
Compare
schlessera
deleted the
fix/use-different-action-for-admin-context-logix
branch
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
-context=adminlogic was hooking some of its logic to theadmin_initaction. However, as the loading was adapted, the requirement for triggering theadmin_initaction ended up within the action's closures, causing the entire construct to not be executed at all.This PR changes the
--context=adminlogic to useinitinstead ofadmin_init, and adds custom (hacky) logic to load the admin environment accordingly.This hacky approach for loading the admin environment is used to ensure we stick with the behavior of whatever WordPress version is being used. Inlining the code would make this hard to accomplish.