Skip to content

fix for root user competition - #5633

Closed
zevilz wants to merge 1 commit into
wp-cli:masterfrom
zevilz:master
Closed

zevilz wants to merge 1 commit into
wp-cli:masterfrom
zevilz:master

Conversation

@zevilz

@zevilz zevilz commented Apr 22, 2022 •

Copy link
Copy Markdown

Completion not working for system root user, warning shows. This fix added --allow-root parameter for getting completions list for root user.

Default behavior:
image

After fix:
image

@zevilz
zevilz requested a review from a team as a code owner April 22, 2022 15:35

@danielbachhuber danielbachhuber left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, @zevilz !

For security reasons, we generally discourage running WP-CLI as root. As such, we'd prefer the user experience the error.

You're welcome to fork utils/wp-completion.bash for your local environment and apply the changes, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants