Fix default mysqli error reporting mode for PHP 8.1+#5582
Merged
schlessera merged 1 commit intomasterfrom Dec 2, 2021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with PHP 8.1,
mysqlihas a new default error reporting mode that throws exceptions.As WordPress handles error conditions on its own, this is not needed.
The default error mode is already adapted with WP Core 5.9+, but on older versions the above changes means that you cannot even update WordPress sites on PHP 8.1, as they fatal with an uncaught exception.
Therefore, WP-CLI also sets the default error reporting mode now to avoid these fatals.