Fix regression that broke extending existing commands#5563
Merged
schlessera merged 2 commits intomasterfrom Nov 11, 2021
Merged
Fix regression that broke extending existing commands#5563schlessera merged 2 commits intomasterfrom
schlessera merged 2 commits intomasterfrom
Conversation
sun
approved these changes
Sep 30, 2021
sun
left a comment
sun
left a comment
There was a problem hiding this comment.
Member
Author
I think that would make it impossible again to override bundled commands, as the new command would just be skipped. |
This was referenced Jan 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a regression in the code that handles command namespaces that made it impossible to extend an existing command class.
This PR reverts the regression and adds a test scenario to ensure this type of extension will not be regressing again.
Fixes #5274