Respect provided verify option in Utils\http_request#5507
Merged
schlessera merged 7 commits intowp-cli:masterfrom May 5, 2021
Merged
Respect provided verify option in Utils\http_request#5507schlessera merged 7 commits intowp-cli:masterfrom
verify option in Utils\http_request#5507schlessera merged 7 commits intowp-cli:masterfrom
Conversation
schlessera
force-pushed
the
fix/5463-utils-http-request-verify-option
branch
from
8bca8ac to
398de67
Compare
Member
|
I rebased and adapted this PR to take the new default behavior from #5514 into account. The main change is that WP-CLI will now default to the system certificate and only fall back to the bundled one if the system-wide certificate failed. |
schlessera
approved these changes
May 5, 2021
schlessera
changed the title
Utils\http_request verify optionverify option in Utils\http_request
Member
|
Thanks for the PR, @aaemnnosttv ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #5463 in that it respects the given value of
$options['verify']rather than overwriting it with the path to the default CA cert.It does this partly by extracting the default CA cert detection/lookup into a new utility:
get_default_cacert.The tests added also include a very simple
Mock_Requests_Transportclass to make testing thehttp_requestcall much cleaner and simpler, but is only used in the added test. Regarding the way this class is loaded, normally I would expect it to be autoloaded but there didn't seem to be any existing configuration for this yet so I left that out for now for simplicity.