Allow root from environment#5448
Merged
schlessera merged 1 commit intowp-cli:masterfrom Oct 31, 2020
freezy-sk:allow-root-env
Merged
Allow root from environment#5448schlessera merged 1 commit intowp-cli:masterfrom freezy-sk:allow-root-env
schlessera merged 1 commit intowp-cli:masterfrom
freezy-sk:allow-root-env
Conversation
schlessera
approved these changes
Oct 31, 2020
Member
|
Thanks for the PR, @freezy-sk ! |
Member
|
I decided to merge this after all, as Docker is becoming more if the default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As already stated in the code they're aware of the risks!
Also good point had @iandunn in #1838 (comment)
Composer (which is used here for running unit and behat test scripts) allows superuser through environment