Add $wp_config_path param for get_wp_config_code()#5366
Add $wp_config_path param for get_wp_config_code()#5366schlessera merged 4 commits intowp-cli:masterfrom
$wp_config_path param for get_wp_config_code()#5366Conversation
|
This should have a test in https://github.com/wp-cli/wp-cli/blob/master/features/wp-config.feature to make sure we don't introduce a regression later on. |
|
@schlessera I am developing behat tests for it. |
|
@schlessera I have added all behat tests for --config-file param in the https://github.com/wp-cli/config-command/pull/104/files I am not understanding which tests I should write for this PR. |
|
@pmbaldha My bad, I don't think we need a test here. This is not externally accessible, and the Behat test from the other package already tests it in terms of safeguarding it against a regression. |
schlessera
left a comment
There was a problem hiding this comment.
You seem to have included both old and new versions in the string... :)
|
Note: GitHub allows you to directly commit suggestions like the one I made above via the |
Co-Authored-By: Alain Schlesser <alain.schlesser@gmail.com>
$wp_config_path param for get_wp_config_code()
Issue: wp-cli/ideas#138