Skip to content

Show full command after using the --prompt flag#5322

Merged
schlessera merged 6 commits intowp-cli:masterfrom
dishitpala:feature/GH-4995
Aug 26, 2020
Merged

Show full command after using the --prompt flag#5322
schlessera merged 6 commits intowp-cli:masterfrom
dishitpala:feature/GH-4995

Conversation

@dishitpala
Copy link
Contributor

@dishitpala dishitpala commented Nov 26, 2019

#4995 Display full command after all prompts are submitted.

Screenshot 2019-11-27 at 2 10 01 AM

@dishitpala dishitpala requested a review from a team as a code owner November 26, 2019 20:42
schlessera
schlessera requested changes Jan 28, 2020
View reviewed changes
Copy link
Member

@schlessera schlessera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should make use of WP_CLI\Utils\assoc_args_to_str() here.

Also, please add a Behat test for this.

@dishitpala
Copy link
Contributor Author

dishitpala commented Feb 17, 2020

@schlessera

  • Address your feedback in this commit
  • Need some time to learn Behat

@schlessera
Copy link
Member

schlessera commented Apr 7, 2020

@dishitpala Are you still up for adding a Behat test here?

@dishitpala
Copy link
Contributor Author

dishitpala commented Aug 16, 2020

@schlessera

By any chance, can we merge this PR and create another issue for a test case?
As I am struggling to manage time to learn Behat.

If we can't merge PR without a test-case, then I will manage to write the test-case.

Please let me know your thought on this.

Thanks.

@schlessera
Copy link
Member

schlessera commented Aug 17, 2020

No worries, I'll look into adding a test to this myself.

@thrijith
Copy link
Member

thrijith commented Aug 22, 2020

No worries, I'll look into adding a test to this myself.

Hi @schlessera, I've taken the liberty to add tests for the change, please let me know if something needs change, Thanks!

Thanks for the PR @dishitpala!

@thrijith thrijith requested a review from schlessera August 22, 2020 14:45
schlessera
schlessera requested changes Aug 26, 2020
View reviewed changes
@schlessera schlessera added this to the 2.5.0 milestone Aug 26, 2020
@schlessera schlessera merged commit 339ee0f into wp-cli:master Aug 26, 2020
@schlessera schlessera changed the title Show full command after using the --prompt flag Show full command after using the --prompt flag Aug 26, 2020
@schlessera
Copy link
Member

schlessera commented Aug 26, 2020

Thanks for the PR, @dishitpala !

@johnbillion johnbillion mentioned this pull request Sep 20, 2022
Closed
@danielbachhuber danielbachhuber mentioned this pull request Nov 9, 2022
Closed
Copilot AI mentioned this pull request Nov 5, 2025
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@schlessera schlessera schlessera approved these changes

Assignees

No one assigned

Labels

parameter:prompt

Projects

None yet

Milestone

2.5.0

Development

Successfully merging this pull request may close these issues.

3 participants

@dishitpala @schlessera @thrijith