Add PHP-version-specific traits to extend the upgrader skin feedback method#5283
Merged
schlessera merged 1 commit intomasterfrom Sep 18, 2019
Merged
Conversation
Member
Author
|
Well, it might look over-complicated, but I wanted to:
|
Member
No worries — I think it's a pretty clever solution, just not entirely obvious. |
schlessera
deleted the
fix-signature-change-in-upgrader-skin-feedback-method
branch
schlessera
added a commit
to wp-cli/widget-command
that referenced
this pull request
Sep 30, 2019
We need to require latest `dev-master` version of the `wp-cli/wp-cli` framework for now because of wp-cli/wp-cli#5283 This should be reverted again once the above PR is part of a stable release of the framework.
schlessera
added a commit
to wp-cli/widget-command
that referenced
this pull request
Jan 5, 2022
We need to require latest `dev-master` version of the `wp-cli/wp-cli` framework for now because of wp-cli/wp-cli#5283 This should be reverted again once the above PR is part of a stable release of the framework.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WordPress trunk is doing refactorings to use more PHP 5.6+ features since the minimum PHP version was raised.
As long as we stick to PHP 5.4, we need to provide compatibility mechanisms to deal with this.
This PR adds a
Compatnamespace to systematically provide compatibility code that can be easily retraced and removed later again.This should solve the build failure found at https://travis-ci.org/wp-cli/wp-cli/jobs/586215547#L736
Related #5282