Skip to content

Add Inflector class and convenience function for pluralizing nouns#4881

Merged
schlessera merged 4 commits intomasterfrom
4880-add-inflector
Aug 3, 2018
Merged

Add Inflector class and convenience function for pluralizing nouns#4881
schlessera merged 4 commits intomasterfrom
4880-add-inflector

Conversation

@schlessera
Copy link
Copy Markdown
Member

Fixes #4880

@schlessera schlessera requested a review from a team August 3, 2018 14:13
@schlessera schlessera added this to the 2.0.0 milestone Aug 3, 2018
@wojsmol
Copy link
Copy Markdown
Contributor

wojsmol commented Aug 3, 2018

@schlessera IMHO no need for public here

public function pluralize( $noun, $count = null ) {

@schlessera
Copy link
Copy Markdown
Member Author

I'm adding tests as well now...

@schlessera
Copy link
Copy Markdown
Member Author

This should be good to go now.

@schlessera schlessera merged commit b32cd0f into master Aug 3, 2018
@schlessera schlessera deleted the 4880-add-inflector branch August 3, 2018 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants