Refactoring wp-cli/wp-cli to represent the framework only, not the bundle#4851
Merged
schlessera merged 86 commits intomasterfrom Aug 3, 2018
Merged
Refactoring wp-cli/wp-cli to represent the framework only, not the bundle#4851schlessera merged 86 commits intomasterfrom
wp-cli/wp-cli to represent the framework only, not the bundle#4851schlessera merged 86 commits intomasterfrom
Conversation
Registering deferred commands from plugins was done on to the hook `find_command_to_run_pre`. This hook is executed multiple times, though. This commit adds a new hook `before_run_command` and attaches the deferred commands to this hook instead, which should only be triggered once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #4748