Skip to content

Remove WP 4.4 requirement#4845

Merged
schlessera merged 4 commits intowp-cli:masterfrom
wojsmol:remove-require-wp-44
Jul 16, 2018
Merged

Remove WP 4.4 requirement#4845
schlessera merged 4 commits intowp-cli:masterfrom
wojsmol:remove-require-wp-44

Conversation

@wojsmol
Copy link
Copy Markdown
Contributor

@wojsmol wojsmol commented Jul 14, 2018

This PR removes WP 4.4 requirement from skip-theme test by using stargazer and buntu themes.

@wojsmol wojsmol force-pushed the remove-require-wp-44 branch from 76e7e97 to 5d61e32 Compare July 15, 2018 06:16
@schlessera
Copy link
Copy Markdown
Member

@wojsmol The tests fail because your check (whether the function theme_setup exists) is wrong.
The parent theme you've picked is built using objects, not using procedural code. So your check needs to look for a class or method, not a function. Use something like the following:

// For stargazer parent theme:
wp eval 'var_export( class_exists( "Stargazer_Theme" ) );'
// For buntu child theme:
wp eval 'var_export( function_exists( "buntu_theme_setup" ) );'

@schlessera schlessera added the scope:testing Related to testing label Jul 16, 2018
@wojsmol
Copy link
Copy Markdown
Contributor Author

wojsmol commented Jul 16, 2018

should be fixed now - thanks

@schlessera schlessera added this to the 2.0.0 milestone Jul 16, 2018
@schlessera schlessera merged commit b0b4462 into wp-cli:master Jul 16, 2018
@schlessera
Copy link
Copy Markdown
Member

Thanks for your continued effort on this, @wojsmol !

@wojsmol wojsmol deleted the remove-require-wp-44 branch July 16, 2018 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:testing Related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants