Closed
Conversation
The build for testing WP-CLI is currently broken on PHP 5.3. Given that: - the current version v2.x is supposed to drop PHP 5.3 support; - PHP 5.3 only runs on Travis within a separate distro, which might not get the same care; - efforts in #4791 to fix the PHP 5.3 build have failed; - no bug reports were provided for the issue the tests on PHP 5.3 flag; => I've decided to just bump the minimum tested version to PHP 5.4 now. Fixes #4791
Member
|
Build failure here too? |
Member
Author
|
Yes, which renders my theory of the problem being specific to the 5.3 Travis environment invalid. |
Member
Author
|
Test failure was fixed via wp-cli/package-command#83 Closing this for now as it is not needed yet. |
Member
Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build for testing WP-CLI is currently broken on PHP 5.3. Given that:
scaffold packagecommand #4791 to fix the PHP 5.3 build have failed;=> I've decided to just bump the minimum tested version to PHP 5.4 now.
Fixes #4791