Skip to content

Require minimum PHP 5.4#4707

Merged
schlessera merged 1 commit intomasterfrom
4554-require-php-5-4
Mar 1, 2018
Merged

Require minimum PHP 5.4#4707
schlessera merged 1 commit intomasterfrom
4554-require-php-5-4

Conversation

@danielbachhuber
Copy link
Copy Markdown
Member

See #4554

@danielbachhuber danielbachhuber added this to the 2.0.0 milestone Feb 27, 2018
@danielbachhuber danielbachhuber requested a review from a team February 27, 2018 14:54
@gitlost
Copy link
Copy Markdown
Contributor

gitlost commented Mar 1, 2018

A bit premature to be doing this isn't it? I think this should be reverted pending discussion and preparation...

@danielbachhuber
Copy link
Copy Markdown
Member Author

A bit premature to be doing this isn't it? I think this should be reverted pending discussion and preparation...

Could you explain further? What additional discussion and preparation is needed?

@gitlost
Copy link
Copy Markdown
Contributor

gitlost commented Mar 1, 2018

Well scaffold package will have to be updated and then all the packages for a start. Nothing can be built at the moment. Plus it's not clear to me this should be a hard requirement anyway

@danielbachhuber
Copy link
Copy Markdown
Member Author

Well scaffold package will have to be updated and then all the packages for a start.

Does that block this?

Nothing can be built at the moment.

Can you point me to this issue?

Plus it's not clear to me this should be a hard requirement anyway

Can you clarify further?

@gitlost
Copy link
Copy Markdown
Contributor

gitlost commented Mar 1, 2018

Does that block this?

This blocks building packages.

Can you point me to this issue?

See wp-cli/extension-command#89 and wp-cli/scaffold-command#131 plus any other attempt to build a package now.

Can you clarify further?

There is nothing in WP-CLI that requires PHP 5.4 for it to run. So a hard requirement is artificial.

@danielbachhuber danielbachhuber removed this from the 2.0.0 milestone Mar 1, 2018
@danielbachhuber
Copy link
Copy Markdown
Member Author

See wp-cli/extension-command#89 and wp-cli/scaffold-command#131 plus any other attempt to build a package now.

Ok, we can revert and come back to it. #4715

There is nothing in WP-CLI that requires PHP 5.4 for it to run. So a hard requirement is artificial.

Yes, that's intentional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants