Append uniq id when extracting file from Phar #4692
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitlost
suggested changes
Feb 19, 2018
php/utils.php
Outdated
| $fname = basename( $path ); | ||
|
|
||
| $tmp_path = get_temp_dir() . "wp-cli-$fname"; | ||
| $tmp_path = get_temp_dir() . "wp-cli-$fname-" . uniqid( 'wp-cli-extract-from-phar-', true ); |
Contributor
There was a problem hiding this comment.
I think it would be better to do this as
get_temp_dir() . uniqid( "wp-cli-extract-from-phar-", true ) . "-$fname";
to keep the extension the same.
Member
Author
There was a problem hiding this comment.
What about:
get_temp_dir() . 'wp-cli-' . uniqid( "wp-cli-extract-from-phar-", true ) . "-$fname";
Contributor
There was a problem hiding this comment.
The wp-cli- bit though is covered by the arg to uniqid()
Member
Author
There was a problem hiding this comment.
Ah, I see:
local ➜ wordpress-develop git:(master) wp shell
wp> $fname = 'router.php';
=> string(10) "router.php"
wp> 'wp-cli-' . uniqid( "wp-cli-extract-from-phar-", true ) . "-$fname";
=> string(66) "wp-cli-wp-cli-extract-from-phar-5a8b0566008283.78459585-router.php"
Contributor
|
Ok this is failing due to #4613, and this check in
with "Yes! We do!". Probably better to revert #4613 than to modify the check...? |
Member
|
Our own break can be fixed either way. Let's discuss reverting during office hours today. |
schlessera
approved these changes
Feb 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4676