Support launching system editor with specific temp file extension#4691
Merged
schlessera merged 3 commits intomasterfrom Feb 20, 2018
Merged
Support launching system editor with specific temp file extension#4691schlessera merged 3 commits intomasterfrom
schlessera merged 3 commits intomasterfrom
Conversation
If the editor does some amount of syntax highlighting, it probably needs the extension to enable the highlighting.
schlessera
requested changes
Feb 19, 2018
php/utils.php
Outdated
| * @return string|bool Edited text, if file is saved from editor; false, if no change to file. | ||
| */ | ||
| function launch_editor_for_input( $input, $filename = 'WP-CLI' ) { | ||
| function launch_editor_for_input( $input, $filename = 'WP-CLI', $ext = 'tmp' ) { |
schlessera
approved these changes
Feb 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the editor does some amount of syntax highlighting, it probably needs
the extension to enable the highlighting.
See wp-cli/config-command#48