Move get_php_binary() to Utils to DRY code.#4483
Merged
danielbachhuber merged 1 commit intomasterfrom Nov 3, 2017
Merged
Conversation
| * Environment values permit specific binaries to be indicated. | ||
| * | ||
| * @access public | ||
| * @category System |
danielbachhuber
approved these changes
Nov 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #4481
Moves body of
WP_CLI::get_php_binary()toUtils\get_php_binary()and removes version inFeatureContextto DRY up code, leaving stubWP_CLI::get_php_binary()for BC. Also changes it to return full Windows path (ie includes.exeextension) for PHP 5.3 for easier testing.Also exports
WP_CLI_PHP_USEDandWP_CLI_PHPinFeature::get_process_env_variables()as could be useful for testing different PHP versions locally.