Only skip @github-api tests when GITHUB_TOKEN isn't present#4481
Merged
danielbachhuber merged 4 commits intomasterfrom Nov 2, 2017
Merged
Only skip @github-api tests when GITHUB_TOKEN isn't present#4481danielbachhuber merged 4 commits intomasterfrom
@github-api tests when GITHUB_TOKEN isn't present#4481danielbachhuber merged 4 commits intomasterfrom
Conversation
Contributor
|
The PHP 5.3 issue is to do with it not having a |
Member
Author
|
@gitlost Cool, thanks |
Contributor
|
Oh just noticed that |
Contributor
|
Ha and also be made static... |
gitlost
approved these changes
Nov 2, 2017
Contributor
gitlost
left a comment
gitlost
left a comment
There was a problem hiding this comment.
I'll leave it to you to merge if you're ok with the further pushes.
(Note will PR some small speed-ups soon re the phar tests in particular which will claw back some of the slow-down in the test runtimes.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From wp-cli/package-command#47