Skip to content

Conversation

@gitlost
Copy link
Contributor

@gitlost gitlost commented Aug 1, 2017

Related wp-cli/package-command#22 (comment)

PR #4185

Add back "Include base project files, because the autoloader will load them" branch, added in #3923, that doesn't seem to be needed, but is.

@schlessera schlessera added this to the 1.3.0 milestone Aug 2, 2017
@schlessera schlessera added the scope:distribution Related to distribution label Aug 2, 2017
@schlessera schlessera merged commit d2840dc into master Aug 2, 2017
@szepeviktor
Copy link
Contributor

szepeviktor commented Aug 2, 2017

Now the phar is only 4 MB.

@gitlost gitlost deleted the issue_4170 branch August 2, 2017 12:18
@gitlost
Copy link
Contributor Author

gitlost commented Aug 2, 2017

Point 4 I hope!

Edit: OMG it is 4MB - was misreading it as 400K.

@gitlost
Copy link
Contributor Author

gitlost commented Aug 2, 2017

There feels something wrong with adding this generally though just to solve a test situation - I think maybe having a 'command' (or something) build option to trigger it would be nicer...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope:distribution Related to distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants