Skip to content

Check for proc_open/close in various scenarios. #4245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danielbachhuber merged 3 commits into from
Jul 26, 2017
Merged

Check for proc_open/close in various scenarios. #4245

danielbachhuber merged 3 commits into from
Jul 26, 2017

Conversation

@gitlost
Copy link
Contributor

@gitlost gitlost commented Jul 26, 2017 •
edited by danielbachhuber
Loading

Fixes #4178

Adds Utils\check_proc_available() and uses it in the 6 places mentioned in #4178 (comment). It fatals on all but Help_Command::pass_through_pager() where it just gives a debug warning.

Edit: changed the tests to be phpunit-based, apart from the group aliases one, but all now use {SRC_DIR}/bin/wp (not the phar) which isn't ideal.

@gitlost
Copy link
Contributor Author

gitlost commented Jul 26, 2017

Okay WP_CLI_PHP_ARGS only works for shell script wp (obs!) so will have to think of something else.

@danielbachhuber danielbachhuber added this to the 1.3.0 milestone Jul 26, 2017
@danielbachhuber danielbachhuber merged commit 73062dd into master Jul 26, 2017
@danielbachhuber danielbachhuber deleted the issue_4178 branch July 26, 2017 11:48
@gitlost gitlost mentioned this pull request Jan 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielbachhuber danielbachhuber danielbachhuber approved these changes

Assignees

No one assigned

Labels

scope:framework

Projects

None yet

Milestone

1.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@gitlost @danielbachhuber