Address new sniffs in WPCS 0.12.0#4241
Merged
gitlost merged 6 commits intowp-cli:masterfrom Jul 24, 2017
Merged
Conversation
gitlost
approved these changes
Jul 24, 2017
Contributor
gitlost
left a comment
gitlost
left a comment
There was a problem hiding this comment.
Thanks v much @chriszarate - was going to do it myself but couldn't get phpcs working locally! The WordPress.WP.CapitalPDangit rule is silly...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some new sniffs that shipped in WPCS
0.12.0raise errors on existing code. This PR updates code so that it will pass checks with PHPCS 0.12.0.It adds one new sniff to the ignore list in
phpcs.ruleset.xml:WordPress.WP.CapitalPDangit. Otherwise, the following line would raise an error, which seems like a spurious objection:https://github.com/wp-cli/wp-cli/blob/master/php/utils-wp.php#L299