Skip to content

Use str_replace instead of preg_replace to normalize doc comment EOLs. #4222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danielbachhuber merged 1 commit into from
Jul 14, 2017
Merged

Use str_replace instead of preg_replace to normalize doc comment EOLs. #4222

danielbachhuber merged 1 commit into from
Jul 14, 2017

Conversation

@gitlost
Copy link
Contributor

@gitlost gitlost commented Jul 13, 2017

Issue #4220 and PR #4221.

Uses str_replace() instead of preg_replace().

Adds Windows tests to CommandFactoryTests, including DOS formatted test files.

@danielbachhuber danielbachhuber added this to the 1.3.0 milestone Jul 14, 2017
@danielbachhuber danielbachhuber merged commit 135f0b4 into master Jul 14, 2017
@danielbachhuber danielbachhuber deleted the str_replace_crlf branch July 14, 2017 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielbachhuber danielbachhuber danielbachhuber approved these changes

Assignees

No one assigned

Labels

scope:framework

Projects

None yet

Milestone

1.3.0

Development

Successfully merging this pull request may close these issues.

2 participants

@gitlost @danielbachhuber