Thanks for the pull request, @electrokit. I appreciate your effort on it.

At this point, I'm 👎 on merging this for a couple of reasons:

1. WP-CLI doesn't formally support Windows because we have no way of running automated tests in a Windows environment. Even if we were able to attain compatibility now, we'd likely regress in the future.
2. With such broad sweeping changes, there's the likelihood of things breaking (as you've already discovered). Even if you get the tests passing, not everything has test coverage, so it's possible something else has broken silently.

Back when there were typewriters CR was moving the cartridge, LF was moving the paper.
Then in computers it was: LF for UNIX, CR for Apple and CRLF for Microsoft.
Then Apple realized LF makes sense.

Nowaday there is "Ubuntu for Windows" https://msdn.microsoft.com/en-us/commandline/wsl/about
In couple of years Windows will support LF - I think...

That last commit is the way to go, following the 2 golden rules in these situations:

1. Normalize your input as early as possible.
2. Denormalize your output as late as possible.

In between you just deal with the normalized input, ie \n in this case. So PHP_EOL and \r shouldn't be used, except at the very beginning/end.

I couldn't resist doing this, see gitlost#14, although it will probably go nowhere. It'd be interesting anyway if you @electrokit could give it a bash (do you have the behat tests running on Windows?).

@danielbachhuber, is the update acceptable? The two changes should not do anything different in *nix environments with files with LF line endings.

@electrokit Yes, I'm fine with this pull request as it stands now.

$docComment = preg_replace( '/\R/', "\n", $docComment );

should just be

$docComment = str_replace( "\r\n", "\n", $docComment );

@gitlost Can you submit in a new PR?

Will do...

$docComment = str_replace( "\r\n", "\n", $docComment );
will break on e.g. Mac OS 9. Maybe not a problem because of the performance increase?

Ha! Also on ZX Spectrums... curious, do you have the behat tests running on Windows?

@electrokit I don't quite understand the Mac OS 9 comment. Was that meant to be a joke or does it reflect a serious consideration?

Mostly a joke, just that I think that \R results in nicer code (removes the definition of newlines away from the code). But for performance reasons alone (around a factor 2), I think the code that @gitlost wrote is better.

👍 Thanks @gfolin

Just so everyone knows, I'm @electrokit as well. Work account.