Skip to content

Conversation

@gitlost
Copy link
Contributor

@gitlost gitlost commented Jun 26, 2017

Issue #4170

Does not include behat or phpunit files.

Tries in general to only include files needed - for instance only specific symfony components, and no spdx-licenses, command, console or Pear stuff for composer.

Excludes "composer/ca-bundle/res/cacert.pem" as it doesn't seem to be needed as "rmccue/requests/library/Requests/Transport/cacert.pem" is used instead.

Processes the autoload_* files to remove unused entries.

Also adds a build option to make a much reduced test phar that can only run cli commands such as wp --version and wp cli check-update - although not used here it will be in a future patch to speed up testing (cli.feature in particular). (See gitlost#12 for the gory details.)

Also removes the "Include base project files, because the autoloader will load them" branch, added in #3923, that doesn't seem to be needed (I think).

@danielbachhuber
Copy link
Member

Thanks @gitlost. It'd be nice to get #4108 running completely before we land this.

@gitlost
Copy link
Contributor Author

gitlost commented Jun 27, 2017

Yes, are there ideas floating around as to how to do that?!

@danielbachhuber
Copy link
Member

Yes, are there ideas floating around as to how to do that?!

@schlessera had it running, but I'm unsure of its current status.

@schlessera
Copy link
Member

I'll try to move #4108 forward, it is one of the tasks I wanted to be done for 1.3.0 as well.

@danielbachhuber danielbachhuber added bug scope:distribution Related to distribution labels Jul 11, 2017
@danielbachhuber danielbachhuber added this to the 1.3.0 milestone Jul 11, 2017
@danielbachhuber
Copy link
Member

@gitlost Happy with this? If so, feel free to merge at your convenience.

I'd like to get this landed sooner rather than later so we can see if any bugs shake out of it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug scope:distribution Related to distribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants